linux-kernel - RE: [PATCH v3 5/5] r8152: Block future register access if register access fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6f10400c04d48fbaa419310c0ae71de@realtek.com>
Date:   Wed, 18 Oct 2023 12:01:02 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Grant Grundler <grundler@...omium.org>,
        Doug Anderson <dianders@...omium.org>
CC:     Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Alan Stern <stern@...land.harvard.edu>,
        Simon Horman <horms@...nel.org>,
        Edward Hill <ecgh@...omium.org>,
        Laura Nao <laura.nao@...labora.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Bjørn Mork <bjorn@...k.no>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH v3 5/5] r8152: Block future register access if register access fails

Grant Grundler <grundler@...omium.org>
> Sent: Wednesday, October 18, 2023 2:06 PM
[...]
> Hayes,
> As Doug points out the probability is really low of this happening for
> an event that is already rare. Doug's patch is a very good step in the
> right direction (driver robustness) and I think has been tested by
> Chromium OS team enough that it is safe to apply to the upstream tree.
> I'm a big fan of taking small steps where we can. We can further
> improve on this in the future as needed.

I don't reject the patch. And, I don't have the right to reject or apply the patch.
I just don't wish the patch to trouble the others. And, I need the professional
people to check me views, too.

I think someone would determine whether the patch could be applied, or not.

Best Regards,
Hayes

> Please add:
> Reviewed-by: Grant Grundler <grundler@...omium.org>
> 
> cheers,
> grant
> 
> >
> > -Doug