[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK7LNARto+DuNH8nuQDtJqJy7hMpozyKiaOkQJ_LYE1utU8XqQ@mail.gmail.com>
Date: Wed, 18 Oct 2023 21:14:26 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
Alex Gaynor <alex.gaynor@...il.com>,
Alexei Starovoitov <ast@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>,
Andreas Hindborg <a.hindborg@...sung.com>,
Andrii Nakryiko <andrii@...nel.org>,
Benno Lossin <benno.lossin@...ton.me>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Boqun Feng <boqun.feng@...il.com>,
Daniel Borkmann <daniel@...earbox.net>,
Gary Guo <gary@...yguo.net>, Hao Luo <haoluo@...gle.com>,
Jiri Olsa <jolsa@...nel.org>,
John Fastabend <john.fastabend@...il.com>,
KP Singh <kpsingh@...nel.org>,
Martin KaFai Lau <martin.lau@...ux.dev>,
Miguel Ojeda <ojeda@...nel.org>,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Nicolas Schier <nicolas@...sle.eu>, Song Liu <song@...nel.org>,
Stanislav Fomichev <sdf@...gle.com>,
Wedson Almeida Filho <wedsonaf@...il.com>,
Yonghong Song <yonghong.song@...ux.dev>, bpf@...r.kernel.org,
rust-for-linux@...r.kernel.org
Subject: Re: [PATCH 2/4] kbuild: avoid too many execution of scripts/pahole-flags.sh
On Wed, Oct 18, 2023 at 12:21 AM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Tue, Oct 17, 2023 at 12:38 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
> >
> > Convert the shell script to a Makefile, which is included only when
> > CONFIG_DEBUG_INFO_BTF=y.
> >
> > [1]: https://savannah.gnu.org/bugs/index.php?64746
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
>
> The field in `MAINTAINERS` should be removed:
>
> F: scripts/pahole-flags.sh
I will replace it with
F: scripts/Makefile.btf
Thanks.
>
> But other than that, it looks good to me! I tried it for a given
> config and it does call `pahole` with the same flags.
>
> Tested-by: Miguel Ojeda <ojeda@...nel.org>
> Acked-by: Miguel Ojeda <ojeda@...nel.org>
>
> Cheers,
> Miguel
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists