[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZS/V7uS/7cGMpDJD@smile.fi.intel.com>
Date: Wed, 18 Oct 2023 15:56:14 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: pmladek@...e.com, rostedt@...dmis.org, linux@...musvillemoes.dk,
senozhatsky@...omium.org, linux-kernel@...r.kernel.org,
Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] lib/vsprintf: Remove redundant code
On Wed, Oct 18, 2023 at 02:48:17PM +0800, Jiapeng Chong wrote:
> When variable needcolon is assigned a value of false, it must be
> assigned a value of true later on, which is redundant code.
>
> lib/vsprintf.c:1411:4: warning: Value stored to 'needcolon' is never read.
...
> @@ -1406,10 +1406,9 @@ char *ip6_compressed_string(char *p, const char *addr)
> i += longest - 1;
> continue;
> }
> - if (needcolon) {
> + if (needcolon)
> *p++ = ':';
> - needcolon = false;
> - }
> +
> /* hex u16 without leading 0s */
> word = ntohs(in6.s6_addr16[i]);
> hi = word >> 8;
Logically you may remove then the assignment to true as well.
But I would double check if it's not a continue missing somewhere or so.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists