linux-kernel - Re: [PATCH] mm: vmscan: the dirty folio unmap redundantly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZS/nszOJM0Qzspip@casper.infradead.org>
Date:   Wed, 18 Oct 2023 15:12:03 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Zhiguo Jiang <justinjiang@...o.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH] mm: vmscan: the dirty folio unmap redundantly

On Wed, Oct 18, 2023 at 09:30:03AM +0800, Zhiguo Jiang wrote:
> If the dirty folio is not reclaimed in the shrink process, it do
> not need to unmap, which can save shrinking time during traversaling
> the dirty folio.

Don't we have to unmap it first in order to make sure that all the
dirty bits from the PTEs have been transferred to the folio dirty bit?