| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231019-feature_ptp_netnext-v6-0-71affc27b0e5@bootlin.com>
Date: Thu, 19 Oct 2023 16:29:15 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Florian Fainelli <florian.fainelli@...adcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Richard Cochran <richardcochran@...il.com>,
Radu Pirea <radu-nicolae.pirea@....nxp.com>,
Jay Vosburgh <j.vosburgh@...il.com>,
Andy Gospodarek <andy@...yhouse.net>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Claudiu Beznea <claudiu.beznea@...on.dev>,
Willem de Bruijn <willemdebruijn.kernel@...il.com>,
Jonathan Corbet <corbet@....net>,
Horatiu Vultur <horatiu.vultur@...rochip.com>,
UNGLinuxDriver@...rochip.com, Simon Horman <horms@...nel.org>,
Vladimir Oltean <vladimir.oltean@....com>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org,
Maxime Chevallier <maxime.chevallier@...tlin.com>,
Kory Maincent <kory.maincent@...tlin.com>,
Jay Vosburgh <jay.vosburgh@...onical.com>
Subject: [PATCH net-next v6 00/16] net: Make timestamping selectable
Up until now, there was no way to let the user select the layer at
which time stamping occurs. The stack assumed that PHY time stamping
is always preferred, but some MAC/PHY combinations were buggy.
This series updates the default MAC/PHY default timestamping and aims to
allow the user to select the desired layer administratively.
Changes in v2:
- Move selected_timestamping_layer variable of the concerned patch.
- Use sysfs_streq instead of strmcmp.
- Use the PHY timestamp only if available.
Changes in v3:
- Expose the PTP choice to ethtool instead of sysfs.
You can test it with the ethtool source on branch feature_ptp of:
https://github.com/kmaincent/ethtool
- Added a devicetree binding to select the preferred timestamp.
Changes in v4:
- Move on to ethtool netlink instead of ioctl.
- Add a netdev notifier to allow packet trapping by the MAC in case of PHY
time stamping.
- Add a PHY whitelist to not break the old PHY default time-stamping
preference API.
Change in v5:
- Update to ndo_hwstamp_get/set. This bring several new patches.
- Add few patches to make the glue.
- Convert macb to ndo_hwstamp_get/set.
- Add netlink specs description of new ethtool commands.
- Removed netdev notifier.
- Split the patches that expose the timestamping to userspace to separate
the core and ethtool development.
- Add description of software timestamping.
- Convert PHYs hwtstamp callback to use kernel_hwtstamp_config.
Change in v6:
- Few fixes from the reviews.
- Replace the allowlist to default_timestamp flag to know which phy is
using old API behavior.
- Rename the timestamping layer enum values.
- Move to a simple enum instead of the mix between enum and bitfield.
- Update ts_info and ts-set in software timestamping case.
Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
---
Kory Maincent (15):
net: Convert PHYs hwtstamp callback to use kernel_hwtstamp_config
net: phy: Remove the call to phy_mii_ioctl in phy_hwstamp_get/set
net: macb: Convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()
net: Make dev_set_hwtstamp_phylib accessible
net: phy: micrel: fix ts_info value in case of no phc
net_tstamp: Add TIMESTAMPING SOFTWARE and HARDWARE mask
net: ethtool: Add a command to expose current time stamping layer
netlink: specs: Introduce new netlink command to get current timestamp
net: ethtool: Add a command to list available time stamping layers
netlink: specs: Introduce new netlink command to list available time stamping layers
net: Replace hwtstamp_source by timestamping layer
net: Change the API of PHY default timestamp to MAC
net: ethtool: ts: Update GET_TS to reply the current selected timestamp
net ethtool: net: Let the active time stamping layer be selectable
netlink: specs: Introduce time stamping set command
Richard Cochran (1):
net: ethtool: Refactor identical get_ts_info implementations.
Documentation/netlink/specs/ethtool.yaml | 57 +++++
Documentation/networking/ethtool-netlink.rst | 63 ++++++
drivers/net/bonding/bond_main.c | 29 +--
drivers/net/ethernet/cadence/macb.h | 15 +-
drivers/net/ethernet/cadence/macb_main.c | 42 +++-
drivers/net/ethernet/cadence/macb_ptp.c | 28 +--
.../net/ethernet/microchip/lan966x/lan966x_main.c | 6 +-
drivers/net/macvlan.c | 14 +-
drivers/net/phy/bcm-phy-ptp.c | 18 +-
drivers/net/phy/dp83640.c | 27 +--
drivers/net/phy/micrel.c | 50 ++---
drivers/net/phy/mscc/mscc_ptp.c | 20 +-
drivers/net/phy/nxp-c45-tja11xx.c | 20 +-
drivers/net/phy/phy.c | 28 ++-
drivers/net/phy/phy_device.c | 37 ++++
drivers/ptp/ptp_ines.c | 16 +-
include/linux/ethtool.h | 8 +
include/linux/mii_timestamper.h | 4 +-
include/linux/net_tstamp.h | 11 +-
include/linux/netdevice.h | 8 +
include/linux/phy.h | 10 +-
include/uapi/linux/ethtool_netlink.h | 29 +++
include/uapi/linux/net_tstamp.h | 18 ++
net/8021q/vlan_dev.c | 15 +-
net/core/dev.c | 3 +
net/core/dev_ioctl.c | 43 ++--
net/core/timestamping.c | 10 +
net/ethtool/Makefile | 2 +-
net/ethtool/common.c | 25 ++-
net/ethtool/common.h | 1 +
net/ethtool/netlink.c | 28 +++
net/ethtool/netlink.h | 4 +
net/ethtool/ts.c | 244 +++++++++++++++++++++
33 files changed, 732 insertions(+), 201 deletions(-)
---
base-commit: 2b2cd9f2c53ea51bdb28203b91b6d518d88b7e03
change-id: 20231011-feature_ptp_netnext-3f278578e84b
Best regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Powered by blists - more mailing lists