linux-kernel - Re: [PATCH] fpga: disable KUnit test suites when module support is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTFBi7vfmEpR9TB0@yilunxu-OptiPlex-7050>
Date:   Thu, 19 Oct 2023 22:47:39 +0800
From:   Xu Yilun <yilun.xu@...ux.intel.com>
To:     gregkh@...uxfoundation.org, Marco Pagani <marpagan@...hat.com>
Cc:     Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
        Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fpga: disable KUnit test suites when module support is
 enabled

On Wed, Oct 18, 2023 at 06:38:13PM +0200, Marco Pagani wrote:
> The fpga core currently assumes that all manager, bridge, and region
> devices have a parent device associated with a driver that can be used
> to take the module's refcount. This behavior causes the fpga test suites
> to crash with a null-ptr-deref since parent fake devices do not have a
> driver. This patch disables all fpga KUnit test suites when loadable
> module support is enabled until the fpga core is fixed. Test suites
> can still be run using the KUnit default UML kernel.
> 
> Signed-off-by: Marco Pagani <marpagan@...hat.com>

LGTM, I've tested on my machine.

Acked-by: Xu Yilun <yilun.xu@...el.com>

Hi Greg:

Could you help review and pull it in for 6.6-final if it's OK.

https://lore.kernel.org/linux-fpga/2023101825-ligament-undergrad-cc4d@gregkh/

Thanks,
Yilun

> ---
>  drivers/fpga/tests/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/fpga/tests/Kconfig b/drivers/fpga/tests/Kconfig
> index e4a64815f16d..d4e55204c092 100644
> --- a/drivers/fpga/tests/Kconfig
> +++ b/drivers/fpga/tests/Kconfig
> @@ -1,6 +1,6 @@
>  config FPGA_KUNIT_TESTS
> -	tristate "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
> -	depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT=y
> +	bool "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
> +	depends on FPGA=y && FPGA_REGION=y && FPGA_BRIDGE=y && KUNIT=y && MODULES=n
>  	default KUNIT_ALL_TESTS
>          help
>            This builds unit tests for the FPGA subsystem
> -- 
> 2.41.0
>