[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023101939-portable-spoof-5fa0@gregkh>
Date: Thu, 19 Oct 2023 17:31:55 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Karolina Stolarek <karolina.stolarek@...el.com>
Cc: Soumya Negi <soumya.negi97@...il.com>,
Martyn Welch <martyn@...chs.me.uk>,
Manohar Vanga <manohar.vanga@...il.com>,
Andi Shyti <andi.shyti@...ux.intel.com>,
Julia Lawall <julia.lawall@...ia.fr>,
outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org,
linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 1/2] staging: vme_user: Replace printk() with
pr_*(),dev_*()
On Thu, Oct 19, 2023 at 12:45:30PM +0200, Karolina Stolarek wrote:
> On 19.10.2023 09:20, Soumya Negi wrote:
> > vme.c uses printk() to log messages. To improve and standardize message
> > formatting, use logging mechanisms pr_err()/pr_warn() and
> > dev_err()/dev_warn() instead. Retain the printk log levels of the
> > messages during replacement.
> >
> > Issue found by checkpatch.pl
> >
> > Signed-off-by: Soumya Negi <soumya.negi97@...il.com>
> > ---
> > Changes in v2:
> > * Change the pr_*() calls used to replace printk's in v1 to dev_*()
> > wherever possible, as it adds more context to the message.
> > (as per feedback from julia.lawall@...ia.fr &
> > gregkh@...uxfoundation.org)
>
> You don't have to include the change log here, as it's already in the cover
> letter. This space is usually used when a patch is not sent as a part of the
> series.
Either or both is fine, this is not a real issue at all, thanks
greg k-h
Powered by blists - more mailing lists