linux-kernel - Re: [PATCH v2 1/2] staging: qlge: Fix coding style in qlge.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231019155556.GJ2100445@kernel.org>
Date:   Thu, 19 Oct 2023 17:55:56 +0200
From:   Simon Horman <horms@...nel.org>
To:     Nandha Kumar Singaram <nandhakumar.singaram@...il.com>
Cc:     Manish Chopra <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com,
        Coiby Xu <coiby.xu@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        netdev@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, kumaran.4353@...il.com
Subject: Re: [PATCH v2 1/2] staging: qlge: Fix coding style in qlge.h

On Thu, Oct 19, 2023 at 06:47:55AM -0700, Nandha Kumar Singaram wrote:
> On Thu, Oct 19, 2023 at 02:27:40PM +0200, Simon Horman wrote:
> > On Wed, Oct 18, 2023 at 12:46:00PM -0700, Nandha Kumar Singaram wrote:
> > > Replace all occurrnces of (1<<x) by BIT(x) to get rid of checkpatch.pl
> > > "CHECK" output "Prefer using the BIT macro"
> > > 
> > > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@...il.com>
> > 
> > Thanks Nandha,
> > 
> > these changes look good to me.
> > But I would like to ask if not updating
> > Q_LEN_V and LEN_V is intentional.
> 
> Thanks for the review Simon.
> 
> I have already sent a patch for Q_LEN_V and LEN_V and it is accepted
> by greg k-h, so didn't updated here.

Understood, in that case this patch looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>