linux-kernel - Re: [PATCH linux-next v3 1/4] sched/psi: Change update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpFwAexdhHubUjrDxs9er7npX6JtX6B78Vkj_pZ+B-1uAw@mail.gmail.com>
Date:   Thu, 19 Oct 2023 09:01:17 -0700
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     yang.yang29@....com.cn
Cc:     mingo@...nel.org, peterz@...radead.org, hannes@...xchg.org,
        mingo@...hat.com, linux-kernel@...r.kernel.org,
        juri.lelli@...hat.com
Subject: Re: [PATCH linux-next v3 1/4] sched/psi: Change update_triggers() to
 a 'void' function

On Tue, Oct 10, 2023 at 1:36 AM <yang.yang29@....com.cn> wrote:
>
> From: Yang Yang <yang.yang29@....com.cn>
>
> Update_triggers() always returns now + group->rtpoll_min_period, and the
> return value is only used by psi_rtpoll_work(), so change update_triggers()
> to a void function, let group->rtpoll_next_update = now +
> group->rtpoll_min_period directly.
>
> This will avoid unnecessary function return value passing & simplifies
> the function.
>
> Suggested-by: Suren Baghdasaryan <surenb@...gle.com>
> Signed-off-by: Yang Yang <yang.yang29@....com.cn>

Sorry for the delay, I was traveling and just got back. I think Ingo
already applied this patch but FWIW

Acked-by: Suren Baghdasaryan <surenb@...gle.com>

> ---
>  kernel/sched/psi.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 1d0f634725a6..be853f227e40 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -434,7 +434,7 @@ static u64 window_update(struct psi_window *win, u64 now, u64 value)
>         return growth;
>  }
>
> -static u64 update_triggers(struct psi_group *group, u64 now, bool *update_total,
> +static void update_triggers(struct psi_group *group, u64 now, bool *update_total,
>                                                    enum psi_aggregators aggregator)
>  {
>         struct psi_trigger *t;
> @@ -503,8 +503,6 @@ static u64 update_triggers(struct psi_group *group, u64 now, bool *update_total,
>                 /* Reset threshold breach flag once event got generated */
>                 t->pending_event = false;
>         }
> -
> -       return now + group->rtpoll_min_period;
>  }
>
>  static u64 update_averages(struct psi_group *group, u64 now)
> @@ -706,7 +704,8 @@ static void psi_rtpoll_work(struct psi_group *group)
>         }
>
>         if (now >= group->rtpoll_next_update) {
> -               group->rtpoll_next_update = update_triggers(group, now, &update_total, PSI_POLL);
> +               update_triggers(group, now, &update_total, PSI_POLL);
> +               group->rtpoll_next_update = now + group->rtpoll_min_period;
>                 if (update_total)
>                         memcpy(group->rtpoll_total, group->total[PSI_POLL],
>                                    sizeof(group->rtpoll_total));
> --
> 2.25.1