linux-kernel - Re: [v4 1/3] drm/panel: ili9882t: Break out as separate driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=V3Y6bSkCivGLgmJS7wQ+U=R=43inqKJYVX-e_rrDpjiQ@mail.gmail.com>
Date:   Thu, 19 Oct 2023 14:49:33 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Cong Yang <yangcong5@...qin.corp-partner.google.com>
Cc:     sam@...nborg.org, neil.armstrong@...aro.org, daniel@...ll.ch,
        hsinyi@...gle.com, linus.walleij@...aro.org, swboyd@...omium.org,
        airlied@...il.com, catalin.marinas@....com, will@...nel.org,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [v4 1/3] drm/panel: ili9882t: Break out as separate driver

Hi,

On Fri, Oct 13, 2023 at 2:19 AM Cong Yang
<yangcong5@...qin.corp-partner.google.com> wrote:
>
> The Starry ILI9882t-based panel should never have been part of the boe
> tv101wum driver, it is clearly based on the Ilitek ILI9882t display
> controller and if you look at the custom command sequences for the
> panel these clearly contain the signature Ilitek page switch (0xff)
> commands. The hardware has nothing in common with the other panels
> supported by this driver.
>
> Break this out into a separate driver and config symbol instead.
>
> If the placement here is out of convenience for using similar code,
> we should consider creating a helper library instead.
>
> Co-developed-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> Signed-off-by: Cong Yang <yangcong5@...qin.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/Kconfig                 |   9 +
>  drivers/gpu/drm/panel/Makefile                |   1 +
>  .../gpu/drm/panel/panel-boe-tv101wum-nl6.c    | 371 ---------
>  drivers/gpu/drm/panel/panel-ilitek-ili9882t.c | 759 ++++++++++++++++++
>  4 files changed, 769 insertions(+), 371 deletions(-)
>  create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9882t.c

Pushed to drm-misc-next:

e2450d32e5fb drm/panel: ili9882t: Break out as separate driver