linux-kernel - Re: [PATCH v2 1/2] arm64: dts: ti: k3-am62p: Add nodes for more IPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e35d333a-7f24-4a3f-90e3-87bc859a18e3@ti.com>
Date:   Thu, 19 Oct 2023 11:25:30 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Bryan Brattlof <bb@...com>, Nishanth Menon <nm@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ARM Linux Mailing List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/2] arm64: dts: ti: k3-am62p: Add nodes for more IPs


> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> index aaf4b793b58e7..e37f19f7e58ea 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> @@ -6,17 +6,35 @@
>  
>  &cbass_wakeup {
>  	wkup_conf: bus@...00000 {
> -		bootph-all;
>  		compatible = "simple-bus";
>  		reg = <0x00 0x43000000 0x00 0x20000>;
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		ranges = <0x00 0x00 0x43000000 0x20000>;
> +		bootph-all;
>  
>  		chipid: chipid@14 {
> -			bootph-all;
>  			compatible = "ti,am654-chipid";
>  			reg = <0x14 0x4>;
> +			bootph-all;
> +		};
> +
> +		cpsw_efuse: syscon@200 {
> +			compatible = "syscon", "simple-mfd";
> +			reg = <0x200 0x4>;

This holds mac-address which is at least 48bits long

> +			bootph-all;
> +		};
> +
> +		usb0_phy_pll_refclk: syscon@...8 {
> +			compatible = "syscon", "simple-mfd";
> +			reg = <0x4008 0x10>;
> +			bootph-all;
> +		};
> +
> +		usb1_phy_pll_refclk: syscon@...8 {
> +			compatible = "syscon", "simple-mfd";
> +			reg = <0x4018 0x10>;
> +			bootph-all;

This adds new dtbs_check warnings:

+/workdir/arch/arm64/boot/dts/ti/k3-am62p5-sk.dtb: syscon@...000: $nodename:0: 'syscon@...000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
+/workdir/arch/arm64/boot/dts/ti/k3-am62p5-sk.dtb: syscon@200: compatible: ['syscon', 'simple-mfd'] is too short
+/workdir/arch/arm64/boot/dts/ti/k3-am62p5-sk.dtb: syscon@...8: compatible: ['syscon', 'simple-mfd'] is too short
+/workdir/arch/arm64/boot/dts/ti/k3-am62p5-sk.dtb: syscon@...8: compatible: ['syscon', 'simple-mfd'] is too short


I suggest to drop them for now.

Please add a new yamls for these nodes or single yaml for top level wkup_conf to 
cover am62/62a/62p SoCs and then introduce the nodes accordingly

Regards
Vignesh