[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dd06c2d3-e273-4356-835b-42619543dfab@linaro.org>
Date: Thu, 19 Oct 2023 09:00:05 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Frank Li <Frank.Li@....com>, miquel.raynal@...tlin.com,
conor.culhane@...vaco.com, alexandre.belloni@...tlin.com,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, corbet@....net, joe@...ches.com,
linux-i3c@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Cc: gregkh@...uxfoundation.org, imx@...ts.linux.dev,
jirislaby@...nel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 1/5] i3c: add slave mode support
On 18/10/2023 23:58, Frank Li wrote:
> Introduce a new slave core layer in order to support slave functions in
> linux kernel. This comprises the controller library and function library.
> Controller library implements functions specific to an slave controller
> and function library implements functions specific to an slave function.
>
> Introduce a new configfs entry to configure the slave function configuring
> and bind the slave function with slave controller.
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> drivers/i3c/Kconfig | 26 ++
> drivers/i3c/Makefile | 2 +
> drivers/i3c/i3c-cfs.c | 389 +++++++++++++++++++++++++++++
> drivers/i3c/slave.c | 453 ++++++++++++++++++++++++++++++++++
> include/linux/i3c/slave.h | 503 ++++++++++++++++++++++++++++++++++++++
> 5 files changed, 1373 insertions(+)
> create mode 100644 drivers/i3c/i3c-cfs.c
> create mode 100644 drivers/i3c/slave.c
> create mode 100644 include/linux/i3c/slave.h
>
> diff --git a/drivers/i3c/Kconfig b/drivers/i3c/Kconfig
> index 30a441506f61c..d5f5ca7cd6a56 100644
> --- a/drivers/i3c/Kconfig
> +++ b/drivers/i3c/Kconfig
> @@ -22,3 +22,29 @@ menuconfig I3C
> if I3C
> source "drivers/i3c/master/Kconfig"
> endif # I3C
> +
> +config I3C_SLAVE
It doesn't look like you follow Kernel naming convention (see coding style).
> + bool "I3C Slave Support"
> + help
> + Support I3C Slave Mode.
> +
Best regards,
Krzysztof
Powered by blists - more mailing lists