linux-kernel - Re: [PATCH v2] ARM: vfp: Add missing VFP instructions to neon_support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZTDW9nflL1TM0svt@shell.armlinux.org.uk>
Date:   Thu, 19 Oct 2023 08:12:54 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Mark-PK Tsai (蔡沛剛) 
        <Mark-PK.Tsai@...iatek.com>
Cc:     "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "xuewen.yan@...soc.com" <xuewen.yan@...soc.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        YJ Chiang (江英杰) <yj.chiang@...iatek.com>
Subject: Re: [PATCH v2] ARM: vfp: Add missing VFP instructions to
 neon_support_hook

On Wed, Oct 11, 2023 at 02:49:44AM +0000, Mark-PK Tsai (蔡沛剛) wrote:
> On Mon, 2023-09-25 at 21:17 +0800, Mark-PK Tsai wrote:
> > Add the missing "Unconditional Advanced SIMD and floating-point
> > instructions" in [1] to the VFP undef hook.
> > 
> > This commit addresses the issue reported in [2], where
> > executing the vudot instruction on a platform with FEAT_DotProd
> > support resulted in an undefined instruction error.
> > 
> > Link: 
> > https://developer.arm.com/documentation/ddi0597/2023-06/?lang=en [1]
> > Link: 
> > https://lore.kernel.org/lkml/20230920083907.30479-1-mark-pk.tsai@mediatek.com/
> >  [2]
> > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@...iatek.com>
> > ---
> >  arch/arm/vfp/vfpmodule.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> > 
> > diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c
> > index 7e8773a2d99d..b68efe643a12 100644
> > --- a/arch/arm/vfp/vfpmodule.c
> > +++ b/arch/arm/vfp/vfpmodule.c
> > @@ -800,6 +800,24 @@ static struct undef_hook neon_support_hook[] =
> > {{
> >  	.cpsr_mask	= PSR_T_BIT,
> >  	.cpsr_val	= PSR_T_BIT,
> >  	.fn		= vfp_support_entry,
> > +}, {
> > +	.instr_mask	= 0xff000800,
> > +	.instr_val	= 0xfc000800,
> > +	.cpsr_mask	= 0,
> > +	.cpsr_val	= 0,
> > +	.fn		= vfp_support_entry,
> > +}, {
> > +	.instr_mask	= 0xff000800,
> > +	.instr_val	= 0xfd000800,
> > +	.cpsr_mask	= 0,
> > +	.cpsr_val	= 0,
> > +	.fn		= vfp_support_entry,
> > +}, {
> > +	.instr_mask	= 0xff000800,
> > +	.instr_val	= 0xfe000800,
> > +	.cpsr_mask	= 0,
> > +	.cpsr_val	= 0,
> > +	.fn		= vfp_support_entry,
> >  }};
> 
> Could someone please kindly review this patch?
> Thanks.

And if someone drops it into the patch system then it might get applied
before the merge window.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!