[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <cover.1697696951.git.soumya.negi97@gmail.com>
Date: Thu, 19 Oct 2023 00:20:08 -0700
From: Soumya Negi <soumya.negi97@...il.com>
To: Martyn Welch <martyn@...chs.me.uk>,
Manohar Vanga <manohar.vanga@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Andi Shyti <andi.shyti@...ux.intel.com>,
Julia Lawall <julia.lawall@...ia.fr>
Cc: outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org,
linux-staging@...ts.linux.dev,
Soumya Negi <soumya.negi97@...il.com>
Subject: [PATCH v2 0/2] staging: vme_user: Replace printk's & clean up log messages
Staging driver vme_user has a bunch of printk() calls in vme.c which
triggers checkpatch warnings. Remove all printk's and change them to
the appropriate logging mechanism i.e pr_err()/pr_warn(), or
dev_err()/dev_warn().
Also, clean up the messages further by using __func__ in the string
instead of function names.
This patchset fixes all checkpatch warnings like:
WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
&
WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
this function's name, in a string
Patches must be applied in order.
Changes in v2:
1. Correct "cleanup" to "clean up" in cover letter. (as per feedback
from julia.lawall@...ia.fr)
2. Patch 1: Change the pr_*() calls used to replace printk's in v1 to
dev_*() wherever possible, as it adds more context to the messages.
(as per feedback from julia.lawall@...ia.fr &
gregkh@...uxfoundation.org)
Soumya Negi (2):
staging: vme_user: Replace printk() with pr_*(),dev_*()
staging: vme_user: Use __func__ instead of function name
drivers/staging/vme_user/vme.c | 193 +++++++++++++++++++--------------
1 file changed, 109 insertions(+), 84 deletions(-)
--
2.42.0
Powered by blists - more mailing lists