linux-kernel - Re: [PATCH v3] wifi: wilc1000: use vmm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2023 07:30:51 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Alexis Lothoré <alexis.lothore@...tlin.com>
Cc:     Claudiu Beznea <claudiu.beznea@...on.dev>,
        Michael Walle <mwalle@...nel.org>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Ajay Singh <ajay.kathat@...rochip.com>,
        Jeff Johnson <quic_jjohnson@...cinc.com>,
        stable@...r.kernel.org,
        Alexis Lothoré <alexis.lothore@...tlin.com>
Subject: Re: [PATCH v3] wifi: wilc1000: use vmm_table as array in wilc struct

Alexis Lothoré <alexis.lothore@...tlin.com> wrote:

> From: Ajay Singh <ajay.kathat@...rochip.com>
> 
> Enabling KASAN and running some iperf tests raises some memory issues with
> vmm_table:
> 
> BUG: KASAN: slab-out-of-bounds in wilc_wlan_handle_txq+0x6ac/0xdb4
> Write of size 4 at addr c3a61540 by task wlan0-tx/95
> 
> KASAN detects that we are writing data beyond range allocated to vmm_table.
> There is indeed a mismatch between the size passed to allocator in
> wilc_wlan_init, and the range of possible indexes used later: allocation
> size is missing a multiplication by sizeof(u32)
> 
> Fixes: 40b717bfcefa ("wifi: wilc1000: fix DMA on stack objects")
> Cc: stable@...r.kernel.org
> Signed-off-by: Ajay Singh <ajay.kathat@...rochip.com>
> Signed-off-by: Alexis Lothoré <alexis.lothore@...tlin.com>
> Reviewed-by: Michael Walle <mwalle@...nel.org>
> Reviewed-by: Jeff Johnson <quic_jjohnson@...cinc.com>

Patch applied to wireless-next.git, thanks.

05ac1a198a63 wifi: wilc1000: use vmm_table as array in wilc struct

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20231017-wilc1000_tx_oops-v3-1-b2155f1f7bee@bootlin.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches