linux-kernel - Re: [PATCH v5 3/3] media: imx-jpeg: Add vendor prefix in slot property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41efe9cd-7574-4827-85c3-845cb3dd3d65@oss.nxp.com>
Date:   Thu, 19 Oct 2023 15:41:06 +0800
From:   ming qian <ming.qian@....nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        mirela.rabulea@....nxp.com, robh+dt@...nel.org, shawnguo@...nel.org
Cc:     krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        mchehab@...nel.org, hverkuil-cisco@...all.nl,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        xiahong.bao@....com, eagle.zhou@....com, tao.jiang_2@....com,
        ming.qian@....com, linux-imx@....com, devicetree@...r.kernel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 3/3] media: imx-jpeg: Add vendor prefix in slot
 property

Hi Krzysztof,

>> From: Ming Qian <ming.qian@....com>
>>
>> The slot property isn't generic property, add vendor prefix. Change the
>> property name to nxp,slot.
>>
>> Fixes: 53ebeea50599 ("media: imx-jpeg: Support to assign slot for encoder/decoder")
>> Signed-off-by: Ming Qian <ming.qian@....com>
>> ---
>> v5
>> - add vender prefix, change property slot to nxp,slot
>>
>> v4
>> - nothing changed here, just modify the bindings and dts
>>
>> v3
>> - nothing changed here, just modify the bindings and dts
>>
>> v2
>> - nothing changed here, just modify the bindings and dts
>>
>>   drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
>> index 64112b63298c..f8b99a292ad1 100644
>> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
>> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
>> @@ -2762,7 +2762,7 @@ static int mxc_jpeg_probe(struct platform_device *pdev)
>>   	if (IS_ERR(jpeg->base_reg))
>>   		return PTR_ERR(jpeg->base_reg);
>>   
>> -	ret = of_property_read_u32_index(pdev->dev.of_node, "slot", 0, &jpeg->slot_data.slot);
> 
> How did it appear in the code and in the DTS without bindings...
> 
> Best regards,
> Krzysztof
> 

In the beginning, I only made the patch set of code and dts, the code
patch can work without dts patch due to the default value. The code
patch is merged to media_tree, but mark the dts patch as ´Not
Applicable´. After that, I sent the dts patch again, but maintainer
reminds me that I need to change the binding too. So I made this patch
set. And I guess the dts patch was merged by mistake.

best regards,
Ming