linux-kernel - Re: [PATCH] drm/loongson: Add support for the DC in LS2K1000 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76nxdwa6m7qyqvala4akc2rptuylhrqyoz2x5rjua4hppoxk7x@wwn37gwuvrms>
Date:   Thu, 19 Oct 2023 10:11:40 +0200
From:   Maxime Ripard <mripard@...nel.org>
To:     Sui Jingfeng <suijingfeng@...ngson.cn>
Cc:     Icenowy Zheng <uwu@...nowy.me>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/loongson: Add support for the DC in LS2K1000 SoC

On Fri, Oct 13, 2023 at 06:28:01PM +0800, Sui Jingfeng wrote:
> Hi,
> 
> 
> On 2023/10/13 16:22, Icenowy Zheng wrote:
> > 在 2023-10-12星期四的 00:26 +0800，Sui Jingfeng写道：
> > > LS2K1000 is a low end SoC (two core 1.0gHz), it don't has dedicated
> > > VRAM.
> > > It requires the framebuffer to be phisically continguous to scanout.
> > > The
> > > display controller in LS2K1000 don't has built-in GPIO hardware, the
> > > structure (register bit field) of its pixel, DC, GPU, DDR PLL are
> > > also
> > > defferent from other model. But for the display controller itself,
> > > Most of
> > > hardware features of it are same with ls7a1000.
> > > 
> > > Below is a simple dts for it.
> > Why don't you write a proper, YAML-formatted binding?
> > 
> This patch use only one DT property, that is the "memory-region = <&display_reserved>;".
> But the memory-region property is a common property, I means that everyone know how to
> use this property. I'm not sure the if YAML documentation is strictly required now.

AFAIK it is, and even if it's not, please do it.

Maxime