[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VevbE=t1V-zCGNXaW=1W2X6CxBGeTD5hUrrH3rWw_tNgw@mail.gmail.com>
Date: Thu, 19 Oct 2023 12:12:18 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Dmitry Rokosov <ddrokosov@...utedevices.com>
Cc: lee@...nel.org, pavel@....cz, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
kernel@...rdevices.ru, rockosov@...il.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org,
George Stark <gnstark@...utedevices.com>
Subject: Re: [PATCH v2 09/11] leds: aw200xx: add support for aw20108 device
On Thu, Oct 19, 2023 at 12:10 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Wed, Oct 18, 2023 at 9:30 PM Dmitry Rokosov
> <ddrokosov@...utedevices.com> wrote:
...
> > - This option enables support for the AW20036/AW20054/AW20072 LED driver.
> > - It is a 3x12/6x9/6x12 matrix LED driver programmed via
> > - an I2C interface, up to 36/54/72 LEDs or 12/18/24 RGBs,
> > + This option enables support for the AW20036/AW20054/AW20072/AW20108
> > + LED driver. It is a 3x12/6x9/6x12/9x12 matrix LED driver programmed via
> > + an I2C interface, up to 36/54/72/108 LEDs or 12/18/24/36 RGBs,
> > 3 pattern controllers for auto breathing or group dimming control.
>
> For better maintenance I always suggest in the cases like this to
> convert help to provide a list of the supported devices, like:
>
> This option enables support for the following Awinic LED drivers:
> - AW20036 (3x12)
(and other specifics can be listed in parentheses, or in free way, but
short enough to occupy only a single line)
> - ...
> ...
>
> And if any new comes to this, it will be just a one liner change.
And you may do that conversion as a precursor to this one and you will
see what I mean.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists