linux-kernel - Re: [PATCH] Bluetooth: btusb: Add return error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2023 12:31:03 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Youwan Wang <youwan@...china.com>
Cc:     marcel@...tmann.org, linux-bluetooth@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: btusb: Add return error code

Dear Youwan,


Thank you for your patch.

It’d be great, if you versioned your patches. For example:

     git format-patch -v3 …

Am 19.10.23 um 04:39 schrieb king:
> From: youwan Wang <youwan@...china.com>
> 
> Signed-off-by: youwan Wang <youwan@...china.com>

It’d be great if you started the first name with an uppercase letter too.

Despite patch diff stats being small and the patch probably trivial, 
it’s common practice to state the motivation for the change nevertheless 
in the commit message body.

> ---
>   drivers/bluetooth/btusb.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index b8e9de887b5d..ec6bdc9687b1 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2826,8 +2826,10 @@ static int btusb_mtk_hci_wmt_sync(struct hci_dev *hdev,
>   		goto err_free_wc;
>   	}
>   
> -	if (data->evt_skb == NULL)
> +	if (data->evt_skb == NULL) {
> +		err = -ENOBUFS;
>   		goto err_free_wc;
> +	}
>   
>   	/* Parse and handle the return WMT event */
>   	wmt_evt = (struct btmtk_hci_wmt_evt *)data->evt_skb->data;


Kind regards,

Paul