linux-kernel - Re: [PATCH net v1 1/1] ethtool: fix clearing of WoL flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231019105437.xvmvfhluowvubp2y@lion.mk-sys.cz>
Date:   Thu, 19 Oct 2023 12:54:37 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Köry Maincent <kory.maincent@...tlin.com>
Cc:     Oleksij Rempel <o.rempel@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Vladimir Oltean <olteanv@...il.com>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net v1 1/1] ethtool: fix clearing of WoL flags

On Thu, Oct 19, 2023 at 12:50:48PM +0200, Michal Kubecek wrote:
[...]
> @@ -490,6 +509,8 @@ ethnl_update_bitset32_verbose(u32 *bitmap, unsigned int nbits,
>  			*mod = true;
>  		}
>  	}
> +	if (saved_bitmap)
> +		*mod = ethnl_bitmap32_cmp(saved_bitmap, bitmap, nbits);
>  
>  	ret = 0;
>  out:

Oops, this should be

		*mod = !ethnl_bitmap32_equal(saved_bitmap, bitmap, nbits);

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)