[<prev] [next>] [day] [month] [year] [list]
Message-ID: <972d21dc-de29-fbac-bf04-efecfdbe565e@redhat.com>
Date: Thu, 19 Oct 2023 14:31:18 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: 艾超 <aichao@...inos.cn>,
"ilpo.jarvinen" <ilpo.jarvinen@...ux.intel.com>,
markgross <markgross@...nel.org>
Cc: linux-kernel <linux-kernel@...r.kernel.org>,
platform-driver-x86 <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v3] platform/x86: inspur-wmi: Add platform profile support
Hi,
On 10/19/23 04:20, 艾超 wrote:
> Hi.
>
>
>> Thanks this is much better.
>
>> Only remaining question I have is can the platform_profile
>> setting be changed by a hotkey (directly by the hotkey,
>> so upon pressing the hotkey the EC changes the platform_profile
>> itself).
>
>> If the answer to this is yes, is there then any event which
>> the driver could listen to and then use to notify userspace
>> about the change by calling platform_profile_notify() upon
>> receiving the event ?
>
>> Or maybe the event will be received by the discussed
>> hotkeys driver, so that can call platform_profile_notify()
>> instead. Note platform_profile_notify() does not require a
>> platform_profile_handler pointer, so it could indeed be
>> called from a separate driver if the events are received
>> elsewhere.
>
>> Regards,
>
>> Hans
>
> There is no any event need to listen by this driver. If user
>
> pressing the hotkey, desktop applications receive
>
> hotkeys(Fn+Q) event, then APP get the currently power mode
> and change it. The desktop applications modify brightness
>
> based on power mode. EC can't changes the power mode
>
> itself.
OK, that is good to know. Thank you for answering
my questions about this.
I believe that once the few small remaining review remarks
are addressed this should be ready for merging then.
Regards,
Hans
Powered by blists - more mailing lists