[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231019133437.24p5sakrile4ceah@skbuf>
Date: Thu, 19 Oct 2023 16:34:37 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Rob Herring <robh@...nel.org>,
Colin Foster <colin.foster@...advantage.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Woojung Huh <woojung.huh@...rochip.com>,
UNGLinuxDriver@...rochip.com,
Linus Walleij <linus.walleij@...aro.org>,
Alvin Šipraga <alsi@...g-olufsen.dk>,
Clément Léger <clement.leger@...tlin.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Magnus Damm <magnus.damm@...il.com>,
Maxime Ripard <mripard@...nel.org>,
nç ÜNAL <arinc.unal@...nc9.com>,
Landen Chao <Landen.Chao@...iatek.com>,
DENG Qingfang <dqfext@...il.com>,
Sean Wang <sean.wang@...iatek.com>,
Daniel Golle <daniel@...rotopia.org>,
John Crispin <john@...ozen.org>,
Gerhard Engleder <gerhard@...leder-embedded.com>,
Heiner Kallweit <hkallweit1@...il.com>,
Sergey Shtylyov <s.shtylyov@....ru>,
Sergei Shtylyov <sergei.shtylyov@...il.com>,
Justin Chen <justin.chen@...adcom.com>,
Florian Fainelli <florian.fainelli@...adcom.com>,
Sekhar Nori <nsekhar@...com>,
Claudiu Manoil <claudiu.manoil@....com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
linux-renesas-soc@...r.kernel.org,
bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH net-next 4/8] dt-bindings: net: ethernet-switch: Add
missing 'ethernet-ports' level
On Mon, Oct 16, 2023 at 04:44:23PM -0500, Rob Herring wrote:
> The '$defs/ethernet-ports' schema is referenced by schemas defining a
> child node 'ethernet-ports', but this schema misses the
> 'ethernet-ports' node. It would work if referring schemas made a
> reference like this:
>
> properties:
> ethernet-ports:
> $ref: ethernet-switch.yaml#/$defs/ethernet-ports
>
> However, that would be different from how dsa.yaml works. For
> consistency, align the schema definition with dsa.yaml and add the
> missing level.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> Documentation/devicetree/bindings/net/ethernet-switch.yaml | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet-switch.yaml b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
> index dcbffe19d71a..688938c2e261 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
> @@ -58,9 +58,11 @@ $defs:
> $ref: '#'
>
> patternProperties:
> - "^(ethernet-)?port@[0-9a-f]+$":
> - description: Ethernet switch ports
> - $ref: ethernet-switch-port.yaml#
> - unevaluatedProperties: false
> + "^(ethernet-)?ports$":
> + patternProperties:
> + "^(ethernet-)?port@[0-9a-f]+$":
> + description: Ethernet switch ports
> + $ref: ethernet-switch-port.yaml#
> + unevaluatedProperties: false
>
> ...
>
> --
> 2.42.0
>
Huh, interesting.
Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
Powered by blists - more mailing lists