linux-kernel - Re: [net-next] net: sched: extend flow action with RSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR18MB4474C304575E55092A2C7377DEDBA@PH0PR18MB4474.namprd18.prod.outlook.com>
Date:   Fri, 20 Oct 2023 16:35:39 +0000
From:   Hariprasad Kelam <hkelam@...vell.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>,
        "amritha.nambiar@...el.com" <amritha.nambiar@...el.com>,
        "sridhar.samudrala@...el.com" <sridhar.samudrala@...el.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [net-next] net: sched: extend flow action with RSS





> On Fri, Oct 20, 2023 at 2:12 AM Hariprasad Kelam <hkelam@...vell.com>
> wrote:
> >
> > This patch extends current flow action with RSS, such that the user
> > can install flower offloads with action RSS followed by a group id.
> > Since this is done in hardware skip_sw flag is enforced.
> 
> Our typical rule for TC is we need s/w equivalence for offloads. How would
> this work in absence of offload?
> 
[Hari]  
Our typical rule for TC is we need s/w equivalence for offloads. How would this work in absence of offload?

This patch we added as an extension to receive queue selection in hardware.
This patch "act_skbedit: skbedit queue mapping for receive queue" enabled receive queue selection in hardware
and skip_sw is enforced.

Adding stakeholders of this patch, to get their opinion.
sridhar.samudrala@...el.com  amritha.nambiar@...el.com

incase of RSS, hardware makes decisions about incoming packets before they are even received in the queue.

Thanks,
Hariprasad k




> cheers,
> jamal
> 
> > Example:
> > In a multi rss group supported NIC,
> >
> > rss group #1 flow hash indirection table populated with rx queues 1 to
> > 4 rss group #2 flow hash indirection table populated with rx queues 5
> > to 9
> >
> > $tc filter add dev eth1 ingress protocol ip flower ip_proto tcp
> > dst_port
> > 443 action skbedit rss_group 1 skip_sw
> >
> > Packets destined to tcp port 443 will be distributed among rx queues 1
> > to 4
> >
> > $tc filter add dev eth1 ingress protocol ip flower ip_proto udp
> > dst_port
> > 8080 action skbedit rss_group 2 skip_sw
> >
> > Packets destined to udp port 8080 will be distributed among rx queues
> > 5 to 9