linux-kernel - Re: [PATCH 2/5] [brcmfmac] Add support for 6G bands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f634ac5-3745-aa5c-612a-0f4efc8764fd@broadcom.com>
Date:   Fri, 20 Oct 2023 20:37:34 +0200
From:   Arend van Spriel <arend.vanspriel@...adcom.com>
To:     Daniel Berlin <dberlin@...rlin.org>
Cc:     Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] [brcmfmac] Add support for 6G bands

On 10/20/2023 6:35 PM, Daniel Berlin wrote:
>>> @@ -6965,6 +7066,10 @@ static int brcmf_construct_chaninfo(struct brcmf_cfg80211_info *cfg,
>>>                for (i = 0; i < band->n_channels; i++)
>>>                        band->channels[i].flags = IEEE80211_CHAN_DISABLED;
>>>        band = wiphy->bands[NL80211_BAND_5GHZ];
>>> +     if (band)
>> Eh. Why is this conditional? We are creating all bands in the wiphy
>> instance so why the null check here?
> 
> I just matched what was there, I can remove all of them if we want.
> 
> (I'll take care of the rest of the comments between here)

I stumbled upon the bandlist usage later in this patch (I think) so we 
do add bands only when the device supports them. Hence you can ignore my 
comment here.

Regards,
Arend

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)