linux-kernel - Re: [PATCH] perf build: Remove stray '\' before that is warned about since grep 3.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTLkWVempj1xV6CV@kernel.org>
Date:   Fri, 20 Oct 2023 17:34:33 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        Ian Rogers <irogers@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf build: Remove stray '\' before that is warned about
 since grep 3.8

Em Tue, Oct 17, 2023 at 12:02:20PM -0700, Namhyung Kim escreveu:
> Hi Arnaldo,
> 
> On Tue, Oct 17, 2023 at 11:15 AM Arnaldo Carvalho de Melo
> <acme@...nel.org> wrote:
> >
> > To address this grep 3.8 warning:
> >
> >   grep: warning: stray \ before #
> >
> > Cc: Adrian Hunter <adrian.hunter@...el.com>
> > Cc: Ian Rogers <irogers@...gle.com>
> > Cc: Jiri Olsa <jolsa@...nel.org>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> > ---
> >  tools/perf/Makefile.perf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> > index 456872ac410df4c0..25d5ccaec22a44fe 100644
> > --- a/tools/perf/Makefile.perf
> > +++ b/tools/perf/Makefile.perf
> > @@ -361,7 +361,7 @@ python-clean := $(call QUIET_CLEAN, python) $(RM) -r $(PYTHON_EXTBUILD) $(OUTPUT
> >  ifeq ($(CONFIG_LIBTRACEEVENT),y)
> >    PYTHON_EXT_SRCS := $(shell grep -v ^\# util/python-ext-sources)
> 
> Do we need to change it here too?  Otherwise looks good

I think I did tests and simply removing the \ in this case will comment
out the rest of the line after the #, IIRC we would have to enclose it
in '', like

  PYTHON_EXT_SRCS := $(shell grep -v '^\#' util/python-ext-sources)

But then if it works as-is, why pollute the patch? :-)

In general the less lines you touch in a patch, the better, don't fix
what isn't broken, helps reviewing, etc. :-)

- Arnaldo
 
> Acked-by: Namhyung Kim <namhyung@...nel.org>
> 
> Thanks,
> Namhyung
> 
> 
> >  else
> > -  PYTHON_EXT_SRCS := $(shell grep -v '^\#\|util/trace-event.c' util/python-ext-sources)
> > +  PYTHON_EXT_SRCS := $(shell grep -v '^#\|util/trace-event.c' util/python-ext-sources)
> >  endif
> >
> >  PYTHON_EXT_DEPS := util/python-ext-sources util/setup.py $(LIBAPI)
> > --
> > 2.41.0
> >

-- 

- Arnaldo