linux-kernel - Re: [PATCH v1] ALSA: SOF: sof-pci-dev: Fix community key quirk detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOReqxhrhzWh-aO5kt-7yqcfX9CbHW-WBgBAqQ9FqeUj-h1o=A@mail.gmail.com>
Date:   Fri, 20 Oct 2023 14:19:23 -0700
From:   Curtis Malainey <cujomalainey@...gle.com>
To:     Mark Hasemeyer <markhas@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Curtis Malainey <cujomalainey@...omium.org>,
        stable@...r.kernel.org,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        sound-open-firmware@...a-project.org
Subject: Re: [PATCH v1] ALSA: SOF: sof-pci-dev: Fix community key quirk detection

Curtis Malainey | Chrome OS Audio Senior Software Engineer |
cujomalainey@...gle.com | Sound Open Firmware Lead


On Fri, Oct 20, 2023 at 2:00 PM Mark Hasemeyer <markhas@...omium.org> wrote:
>
> Some Chromebooks do not populate the product family DMI value resulting
> in firmware load failures.
>
> Add another quirk detection entry that looks for "Google" in the BIOS
> version. Theoretically, PRODUCT_FAMILY could be replaced with
> BIOS_VERSION, but it is left as a quirk to be conservative.
>
> Cc: stable@...r.kernel.org
> Signed-off-by: Mark Hasemeyer <markhas@...omium.org>

Acked-by: Curtis Malainey <cujomalainey@...omium.org>

> ---
>
>  sound/soc/sof/sof-pci-dev.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/sound/soc/sof/sof-pci-dev.c b/sound/soc/sof/sof-pci-dev.c
> index 1d706490588e..64b326e3ef85 100644
> --- a/sound/soc/sof/sof-pci-dev.c
> +++ b/sound/soc/sof/sof-pci-dev.c
> @@ -145,6 +145,13 @@ static const struct dmi_system_id community_key_platforms[] = {
>                         DMI_MATCH(DMI_PRODUCT_FAMILY, "Google"),
>                 }
>         },
> +       {
> +               .ident = "Google firmware",
> +               .callback = chromebook_use_community_key,
> +               .matches = {
> +                       DMI_MATCH(DMI_BIOS_VERSION, "Google"),
> +               }
> +       },
>         {},
>  };
>
> --
> 2.42.0.655.g421f12c284-goog
>