linux-kernel - Re: [PATCH] mmc: cqhci: Be more verbose in error irq handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <613c51f0-c32e-4de5-9627-525d92fb06ed@intel.com>
Date:   Fri, 20 Oct 2023 10:40:52 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Kornel Dulęba <korneld@...omium.org>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Ritesh Harjani <riteshh@...eaurora.org>,
        Asutosh Das <quic_asutoshd@...cinc.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Radoslaw Biernacki <biernacki@...gle.com>,
        Guenter Roeck <groeck@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>, upstream@...ihalf.com
Subject: Re: [PATCH] mmc: cqhci: Be more verbose in error irq handler

On 16/10/23 12:56, Kornel Dulęba wrote:
> There are several reasons for controller to generate an error interrupt.
> They include controller<->card timeout, and CRC mismatch error.
> Right now we only get one line in the logs stating that CQE recovery was
> triggered, but with no information about what caused it.
> To figure out what happened be more verbose and dump the registers from
> irq error handler logic.
> This matches the behaviour of the software timeout logic, see
> cqhci_timeout.
> 
> Signed-off-by: Kornel Dulęba <korneld@...omium.org>
> ---
>  drivers/mmc/host/cqhci-core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
> index b3d7d6d8d654..33abb4bd53b5 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -700,8 +700,9 @@ static void cqhci_error_irq(struct mmc_host *mmc, u32 status, int cmd_error,
>  
>  	terri = cqhci_readl(cq_host, CQHCI_TERRI);
>  
> -	pr_debug("%s: cqhci: error IRQ status: 0x%08x cmd error %d data error %d TERRI: 0x%08x\n",
> -		 mmc_hostname(mmc), status, cmd_error, data_error, terri);
> +	pr_warn("%s: cqhci: error IRQ status: 0x%08x cmd error %d data error %d\n",
> +		 mmc_hostname(mmc), status, cmd_error, data_error);
> +	cqhci_dumpregs(cq_host);

For debugging, isn't dynamic debug seems more appropriate?

>  
>  	/* Forget about errors when recovery has already been triggered */
>  	if (cq_host->recovery_halt)