linux-kernel - Re: [PATCH v5] alpha: Clean-up the panic notifier code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTIx4-Sn3mzYFzke@alley>
Date:   Fri, 20 Oct 2023 09:53:07 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     "Guilherme G. Piccoli" <gpiccoli@...lia.com>
Cc:     "Maciej W. Rozycki" <macro@...am.me.uk>,
        linux-alpha@...r.kernel.org, mattst88@...il.com,
        linux-kernel@...r.kernel.org, kernel-dev@...lia.com,
        kernel@...ccoli.net, Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Richard Henderson <richard.henderson@...aro.org>
Subject: Re: [PATCH v5] alpha: Clean-up the panic notifier code

On Sun 2023-10-15 15:54:49, Guilherme G. Piccoli wrote:
> On 10/10/2023 02:16, Maciej W. Rozycki wrote:
> > On Sat, 2 Sep 2023, Guilherme G. Piccoli wrote:
> > 
> >> So, let's clean the code and set the notifier to run as the
> >> latest, following the same approach other architectures are
> >> doing - also, remove the unnecessary include of a header already
> >> included indirectly.
> > 
> >  FWIW my understanding is our current policy is not to rely on indirect 
> > inclusions and if a given source relies on declarations or definitions 
> > provided by a header, then it is supposed to pull it explicitly.
> > 
> >  And in any case such an unrelated self-contained change is expected to be 
> > sent as a separate patch, in a series if there's a mechanical dependency.
> > 
> >   Maciej
> > 
> 
> Hi Maciej, thanks for your review!
> 
> I'm not sure how the indirect inclusion is happening here. The only
> notifier present in this file is a panic notifier, and for this one, we
> have the "panic_notifier.h" header. It's like this for many others (if
> not all) panic notifiers in the kernel.

IMHO, including linux/panic_notifier.h should be enough. It is includes
linux/notifier.h by definition.

Well, it is not a big deal to keep the include. Let's not block the
change because of this.

> Regarding split in another patch, it can easily be done, but I think
> it's quite self-contained now, a simple patch that cleans-up the alpha
> notifier. I've done that for other notifiers so far, but I'm OK either
> way, as long maintainers are happy and community agrees =)

If I was the maintainer, I would prefer the split as well ;-)
I mean to move the code in one patch and do the changes in
a followup patch.

It is much easier for review. It is more clear what are the real
changes and that there are only wanted changes.

Even removal of the include might be in a separate patch. It helps
to find regressions by bisecting. The eventual revert is easier.
Also it does not block the other changes ;-)

Best Regards,
Petr