[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231020084620.4603-1-ante.knezic@helmholz.de>
Date: Fri, 20 Oct 2023 10:46:20 +0200
From: Ante Knezic <ante.knezic@...mholz.de>
To: <olteanv@...il.com>
CC: <UNGLinuxDriver@...rochip.com>, <andrew@...n.ch>,
<ante.knezic@...mholz.de>, <conor+dt@...nel.org>,
<davem@...emloft.net>, <devicetree@...r.kernel.org>,
<edumazet@...gle.com>, <f.fainelli@...il.com>,
<krzysztof.kozlowski+dt@...aro.org>, <kuba@...nel.org>,
<linux-kernel@...r.kernel.org>, <marex@...x.de>,
<netdev@...r.kernel.org>, <pabeni@...hat.com>,
<robh+dt@...nel.org>, <woojung.huh@...rochip.com>
Subject: Re: [PATCH net-next v3 2/2] net:dsa:microchip: add property to select
On Thu, 19 Oct 2023 19:54:09 +0300, Vladimir Oltean wrote:
> So user ports and CPU ports meet at ksz8_port_setup() from different
> call paths, but I think it's strange to continue this coding pattern for
> port stuff that's not common between user ports and CPU ports. For that
> reason, the placement of the existing ksz8795_cpu_interface_select() is
> also weird, when it could have been directly placed under
> ksz8_config_cpu_port(), and it would have not confusingly shared a code
> path with user ports.
>
> Could you please add a dedicated ksz88x3_config_rmii_clk(), called
> directly from ksz8_config_cpu_port()? It can have this as first step:
>
> if (!ksz_is_ksz88x3(dev))
> return 0;
>
> and then the rest of the code can have a single level of indentation,
> which would look much more natural.
Ok, will do. I am guessing I should leave the existing
ksz8795_cpu_interface_select() as it is?
Powered by blists - more mailing lists