[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20231020090237.201029-1-suhui@nfschina.com>
Date: Fri, 20 Oct 2023 17:02:38 +0800
From: Su Hui <suhui@...china.com>
To: ping.cheng@...om.com, jason.gerecke@...om.com, jikos@...nel.org,
benjamin.tissoires@...hat.com
Cc: Su Hui <suhui@...china.com>, linux-input@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH] HID: wacom_sys: add error code check in wacom_feature_mapping
hid_report_raw_event() can return error code like '-ENOMEM' if
failed, so check 'ret' to make sure all things work fine.
Signed-off-by: Su Hui <suhui@...china.com>
---
drivers/hid/wacom_sys.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 3f704b8072e8..1f898d4ee708 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -320,6 +320,8 @@ static void wacom_feature_mapping(struct hid_device *hdev,
if (ret == n && features->type == HID_GENERIC) {
ret = hid_report_raw_event(hdev,
HID_FEATURE_REPORT, data, n, 0);
+ if (ret)
+ hid_warn(hdev, "failed to report feature\n");
} else if (ret == 2 && features->type != HID_GENERIC) {
features->touch_max = data[1];
} else {
@@ -381,6 +383,8 @@ static void wacom_feature_mapping(struct hid_device *hdev,
if (ret == n) {
ret = hid_report_raw_event(hdev, HID_FEATURE_REPORT,
data, n, 0);
+ if (ret)
+ hid_warn(hdev, "failed to report feature\n");
} else {
hid_warn(hdev, "%s: could not retrieve sensor offsets\n",
__func__);
--
2.30.2
Powered by blists - more mailing lists