linux-kernel - [PATCH] leds: lp5521: add an error check in lp5521_post_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231020091930.207870-1-suhui@nfschina.com>
Date:   Fri, 20 Oct 2023 17:19:31 +0800
From:   Su Hui <suhui@...china.com>
To:     pavel@....cz, lee@...nel.org
Cc:     Su Hui <suhui@...china.com>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH] leds: lp5521: add an error check in lp5521_post_init_device

lp55xx_write() can return an error code, add a check for this.

Signed-off-by: Su Hui <suhui@...china.com>
---
 drivers/leds/leds-lp5521.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
index 2ef19ad23b1d..f9c8b568b652 100644
--- a/drivers/leds/leds-lp5521.c
+++ b/drivers/leds/leds-lp5521.c
@@ -301,6 +301,8 @@ static int lp5521_post_init_device(struct lp55xx_chip *chip)
 
 	/* Set all PWMs to direct control mode */
 	ret = lp55xx_write(chip, LP5521_REG_OP_MODE, LP5521_CMD_DIRECT);
+	if (ret)
+		return ret;
 
 	/* Update configuration for the clock setting */
 	val = LP5521_DEFAULT_CFG;
-- 
2.30.2