linux-kernel - Re: [PATCH] b43legacy: Removed unneeded variable in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231020113514.122bfb6e@barney>
Date:   Fri, 20 Oct 2023 11:35:14 +0200
From:   Michael Büsch <m@...s.ch>
To:     Bragatheswaran Manickavel <bragathemanick0908@...il.com>
Cc:     Larry.Finger@...inger.net, kvalo@...nel.org,
        linux-wireless@...r.kernel.org, b43-dev@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] b43legacy: Removed unneeded variable in debugfs

On Fri, 20 Oct 2023 14:57:35 +0530
Bragatheswaran Manickavel <bragathemanick0908@...il.com> wrote:

> Removed unneeded variable. Issue identified using Coccinelle semantic.
> No functional impact

This patch is completely wrong. It would not even compile.
Please compile your patches before submitting them!

And it is the second time we see this nonsense.
The code is correct as-is. There is no unused variable.

NACK.

-- 
Michael Büsch
https://bues.ch/

Content of type "application/pgp-signature" skipped