linux-kernel - [PATCH v3 0/5] staging: vme_user: Remove printk's & clean up log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <cover.1697763267.git.soumya.negi97@gmail.com>
Date:   Thu, 19 Oct 2023 18:55:18 -0700
From:   Soumya Negi <soumya.negi97@...il.com>
To:     Martyn Welch <martyn@...chs.me.uk>,
        Manohar Vanga <manohar.vanga@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        julia.lawall@...ia.fr, Andi Shyti <andi.shyti@...nel.org>
Cc:     outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev,
        Soumya Negi <soumya.negi97@...il.com>
Subject: [PATCH v3 0/5] staging: vme_user: Remove printk's & clean up log messages

Staging driver vme_user has a bunch of printk() calls in vme.c which
triggers checkpatch warnings. Remove all printk's by either changing
them to the appropriate logging mechanism i.e dev_err()/dev_warn() or
by dropping the unneeded printk's.

Also, clean up the messages further by using __func__ in the string
instead of function names.

This patchset fixes all checkpatch warnings like:

    WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
             dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
&
    WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
             this function's name, in a string

Patches must be applied in order.

Changes in v3:
 1. Patch 1: Use only dev_err() to replace printk(). v2 replaced some
    of the printk's using pr_err(). Leave the calls as printk's. New 
    patches added in v3 handle these printk's. 
    (as per feedback from gregkh@...uxfoundation.org)
 2. Added Patch 3: Remove unneeded printk.
    (suggested by gregkh@...uxfoundation.org)
 3. Added Patch 4: Remove NULL-checks for bridge device & resource.
    Corresponding printk's(part of the check blocks) are removed too.
    (as per feedback from gregkh@...uxfoundation.org)
 4. Added Patch 5: Replace printk with dev_err() in vme_check_window()
    Since vme_check_window() doesn't have access to bridge device, pass
    the bridge pointer to it.
    (suggested by gregkh@...uxfoundation.org) 
 5. Edit cover letter subject & body according to patches added in v3.

Changes in v2:
 1. Correct "cleanup" to "clean up" in cover letter.   (as per feedback
    from julia.lawall@...ia.fr)
 2. Patch 1: Change the pr_*() calls used to replace printk's in v1 to 
    dev_*() wherever possible, as it adds more context to the messages.
    (as per feedback from julia.lawall@...ia.fr & 
    gregkh@...uxfoundation.org)

Soumya Negi (5):
  staging: vme_user: Replace printk() with dev_*()
  staging: vme_user: Use __func__ instead of function name
  staging: vme_user: Remove printk() in find_bridge()
  staging: vme_user: Remove NULL-checks
  staging: vme_user: Use dev_err() in vme_check_window()

 drivers/staging/vme_user/vme.c | 222 ++++++++++++++++-----------------
 drivers/staging/vme_user/vme.h |   4 +-
 2 files changed, 108 insertions(+), 118 deletions(-)

-- 
2.42.0