[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZTJYgnugWHwBhtxv@smile.fi.intel.com>
Date: Fri, 20 Oct 2023 13:37:54 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Raag Jadav <raag.jadav@...el.com>
Cc: rafael@...nel.org, len.brown@...el.com, robert.moore@...el.com,
mika.westerberg@...ux.intel.com, mark.rutland@....com,
will@...nel.org, linux@...ck-us.net, linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org,
acpica-devel@...ts.linuxfoundation.org, linux-gpio@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-hwmon@...r.kernel.org,
mallikarjunappa.sangannavar@...el.com, bala.senthil@...el.com
Subject: Re: [PATCH v1 5/8] ACPI: x86: use acpi_dev_uid_match() for matching
_UID
On Fri, Oct 20, 2023 at 02:17:29PM +0530, Raag Jadav wrote:
> Convert manual _UID references to use standard ACPI helpers.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
...
> - if (!adev->pnp.unique_id ||
> - strcmp(adev->pnp.unique_id, override_status_ids[i].uid))
> + if (!acpi_dev_uid_match(adev, override_status_ids[i].uid))
The check for NULL argument inside that API does not affect the behaviour as
otherwise it will be a crash with the current implementation.
> continue;
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists