linux-kernel - Re: [PATCH v2] stop_machine: Avoid potential non-atomic read of multi_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231020104802.GB33965@noisy.programming.kicks-ass.net>
Date:   Fri, 20 Oct 2023 12:48:02 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     Rong Tao <rtoax@...mail.com>, elver@...gle.com,
        linux-kernel@...r.kernel.org, rongtao@...tc.cn, tglx@...utronix.de
Subject: Re: [PATCH v2] stop_machine: Avoid potential non-atomic read of
 multi_stop_data::state

On Fri, Oct 20, 2023 at 11:23:37AM +0100, Mark Rutland wrote:

> > And replace smp_wmb()+WRITE_ONCE() with smp_store_release().
> 
> This is also fine, but feels like a logically separate change.

Agreed, and please take this opportunity to write a comment with the
barrier.