[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c869b3a0-1986-4507-8466-ea1b5f93e2c0@linaro.org>
Date: Fri, 20 Oct 2023 13:12:38 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: ming qian <ming.qian@....nxp.com>, mirela.rabulea@....nxp.com,
robh+dt@...nel.org, shawnguo@...nel.org
Cc: krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
mchehab@...nel.org, hverkuil-cisco@...all.nl,
s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
xiahong.bao@....com, eagle.zhou@....com, tao.jiang_2@....com,
ming.qian@....com, linux-imx@....com, devicetree@...r.kernel.org,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 3/3] media: imx-jpeg: Add vendor prefix in slot
property
On 19/10/2023 09:41, ming qian wrote:
>>> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
>>> index 64112b63298c..f8b99a292ad1 100644
>>> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
>>> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
>>> @@ -2762,7 +2762,7 @@ static int mxc_jpeg_probe(struct platform_device *pdev)
>>> if (IS_ERR(jpeg->base_reg))
>>> return PTR_ERR(jpeg->base_reg);
>>>
>>> - ret = of_property_read_u32_index(pdev->dev.of_node, "slot", 0, &jpeg->slot_data.slot);
>>
>> How did it appear in the code and in the DTS without bindings...
>>
>> Best regards,
>> Krzysztof
>>
>
> In the beginning, I only made the patch set of code and dts, the code
> patch can work without dts patch due to the default value. The code
> patch is merged to media_tree, but mark the dts patch as ´Not
> Applicable´. After that, I sent the dts patch again, but maintainer
> reminds me that I need to change the binding too. So I made this patch
> set. And I guess the dts patch was merged by mistake.
The code was merged by mistake. You cannot add of_property() ABI to the
Linux without documenting it via bindings. Don't send such patches.
Best regards,
Krzysztof
Powered by blists - more mailing lists