linux-kernel - Re: [PATCH] selftests/clone3: Skip new time namespace test when unsupported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bca5db5e-2536-4e3f-8d04-7e0e13203ad6@sirena.org.uk>
Date:   Fri, 20 Oct 2023 12:46:37 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Christian Brauner <brauner@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Tobias Klauser <tklauser@...tanz.ch>,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests/clone3: Skip new time namespace test when
 unsupported

On Thu, Oct 19, 2023 at 04:35:38PM -0700, Andrew Morton wrote:
> On Fri, 20 Oct 2023 00:08:12 +0100 Mark Brown <broonie@...nel.org> wrote:

> > Use a filter function to skip the time namespace test on systems with
> > !CONFIG_TIME_NS. This reworks a fix originally done by Tiezhu Yang prior
> > to the refactoring in 34dce23f7e40 ("selftests/clone3: Report descriptive
> > test names"). The changelog from their fix explains the issue very clearly:

> I was about to send Tiezhu Yang's fix to Linus.   I'll rebase mm-hotfixes-stable
> to drop that patch, so you own it now!

> Please note that your version lacks an explicit cc:stable, but I suppose the
> stablebots will scoop it up anyway.

I think I was expecting Tiezhu's version to still get sent and then the
two versions to get merged - the refactoring that caused the conflict is
very clearly not stable material.

> > Original-fix-from: Tiezhu Yang <yangtiezhu@...ngson.cn>

> "Original-fix-from" isn't a thing.  In fact it seems to be the first
> time this has been used.  Grepping for  "Original-.*:" shows
> all sorts of innovations, including "Based-on-the-original-screenplay-by:".

> I guess Documentation/process/submitting-patches.rst and checkpatch
> lost this fight a long time ago.

Well, they've always been documenting existing practice.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)