linux-kernel - Re: [PATCH] rtc: at91rm9200: annotate at91_rtc_remove with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c339d334-5fe4-4c1a-81ee-42882d93f3e5@microchip.com>
Date:   Fri, 20 Oct 2023 14:46:43 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     <alexandre.belloni@...tlin.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Claudiu Beznea <claudiu.beznea@...on.dev>
CC:     kernel test robot <lkp@...el.com>, <linux-rtc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: at91rm9200: annotate at91_rtc_remove with __exit
 again

On 16/10/2023 at 06:18, alexandre.belloni@...tlin.com wrote:
> From: Alexandre Belloni <alexandre.belloni@...tlin.com>
> 
> Without __exit, having the driver as a builtin after dropping the __exit
> annotation results in:
> 
>>> drivers/rtc/rtc-at91rm9200.c:561:13: warning: 'at91_rtc_remove' defined but not used [-Wunused-function]
>       561 | static void at91_rtc_remove(struct platform_device *pdev)
>           |             ^~~~~~~~~~~~~~~
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310160705.vlElNOGb-lkp@intel.com/
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
Thanks Alexandre, best regards,
   Nicolas

> ---
>   drivers/rtc/rtc-at91rm9200.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index 3f5ff9867c02..c16fe711a0d9 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -558,7 +558,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev)
>   /*
>    * Disable and remove the RTC driver
>    */
> -static void at91_rtc_remove(struct platform_device *pdev)
> +static void __exit at91_rtc_remove(struct platform_device *pdev)
>   {
>          /* Disable all interrupts */
>          at91_rtc_write_idr(AT91_RTC_ACKUPD | AT91_RTC_ALARM |
> --
> 2.41.0
>