linux-kernel - Re: [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <938e1b53-8b5a-441e-ab8b-a40cebee926b@linaro.org>
Date:   Fri, 20 Oct 2023 15:28:25 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Kevin Hilman <khilman@...libre.com>, Yu Tu <yu.tu@...ogic.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Dmitry Rokosov <ddrokosov@...rdevices.ru>,
        Jian Hu <jian.hu@...ogic.com>,
        linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS

On 20/10/2023 15:19, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Without this, the newly added driver fails to link:
> 
> aarch64-linux-ld: drivers/clk/meson/s4-pll.o: in function `meson_s4_pll_probe':
> s4-pll.c:(.text+0x13c): undefined reference to `meson_clk_hw_get'
> 
> Fixes: e787c9c55edad ("clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/clk/meson/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> index c5303e4c16043..3c28560b0faba 100644
> --- a/drivers/clk/meson/Kconfig
> +++ b/drivers/clk/meson/Kconfig
> @@ -149,6 +149,7 @@ config COMMON_CLK_S4_PLL
>   	tristate "S4 SoC PLL clock controllers support"
>   	depends on ARM64
>   	default y
> +	select COMMON_CLK_MESON_CLKC_UTILS
>   	select COMMON_CLK_MESON_MPLL
>   	select COMMON_CLK_MESON_PLL
>   	select COMMON_CLK_MESON_REGMAP

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>