linux-kernel - Re: [PATCH net-next v4 1/2] dt-bindings: net: microchip,ksz: document microchip,rmii-clk-internal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231020-agency-yapping-17ba240510c0@spud>
Date:   Fri, 20 Oct 2023 16:45:38 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Ante Knezic <ante.knezic@...mholz.de>
Cc:     netdev@...r.kernel.org, woojung.huh@...rochip.com, andrew@...n.ch,
        f.fainelli@...il.com, olteanv@...il.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, marex@...x.de, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, UNGLinuxDriver@...rochip.com,
        o.rempel@...gutronix.de
Subject: Re: [PATCH net-next v4 1/2] dt-bindings: net: microchip,ksz:
 document microchip,rmii-clk-internal

On Fri, Oct 20, 2023 at 04:25:03PM +0200, Ante Knezic wrote:
> Add documentation for selecting reference rmii clock on KSZ88X3 devices
> 
> Signed-off-by: Ante Knezic <ante.knezic@...mholz.de>

Something in the commit message explaining why a property is needed
rather than using the regular old clocks property would be good.
Please do that if you re-spin. Otherwise,

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

(and despite the domain, I have nothing to do with switches...)

Cheers,
Conor.

> ---
>  .../devicetree/bindings/net/dsa/microchip,ksz.yaml      | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index 41014f5c01c4..624feb1bb9be 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -72,6 +72,23 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  microchip,rmii-clk-internal:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Set if the RMII reference clock is provided internally. Otherwise
> +      reference clock should be provided externally.
> +
> +if:
> +  not:
> +    properties:
> +      compatible:
> +        enum:
> +          - microchip,ksz8863
> +          - microchip,ksz8873
> +then:
> +  properties:
> +    microchip,rmii-clk-internal: false
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.11.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)