linux-kernel - Re: [PATCH] staging: greybus: camera: fixes alignment should match open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <de77b29e-fb65-407d-ab77-f4a2a77a8422@kadam.mountain>
Date:   Fri, 20 Oct 2023 18:55:34 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Chen Shuo <1289151713@...com>
Cc:     greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: camera: fixes alignment should match
 open parenthesis

On Fri, Oct 20, 2023 at 11:12:03PM +0800, Chen Shuo wrote:
> This patch fixes the checks reported by checkpatch.pl
> for alignment should match open parenthesis
> 
> Signed-off-by: Chen Shuo <1289151713@...com>
> ---
>  drivers/staging/greybus/camera.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index cdbb42cd413b..ed9e16bab4cc 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -378,7 +378,7 @@ struct ap_csi_config_request {
>  #define GB_CAMERA_CSI_CLK_FREQ_MARGIN		150000000U
>  
>  static int gb_camera_setup_data_connection(struct gb_camera *gcam,
> -		struct gb_camera_configure_streams_response *resp,
> +					   struct gb_camera_configure_streams_response *resp,
>  		struct gb_camera_csi_params *csi_params)
>  {

Just leave it as-is.  The original was fine.  I know that these days
we can go over the 80 character mark but, really, does this make things
easier to read?

regards,
dan carpenter