[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023102131-slacker-lily-28ff@gregkh>
Date: Sat, 21 Oct 2023 11:48:32 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Nandha Kumar Singaram <nandhakumar.singaram@...il.com>
Cc: Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: Alignment should match open parenthesis
On Thu, Oct 19, 2023 at 02:39:49PM -0700, Nandha Kumar Singaram wrote:
> Adhere to linux coding style. Reported by checkpatch.pl:
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@...il.com>
> ---
> drivers/staging/greybus/camera.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index cdbb42cd413b..405c8e78aa72 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection,
> }
>
> static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
> - struct gb_camera_configure_streams_response *resp)
> + struct gb_camera_configure_streams_response *resp)
> {
> unsigned int max_pkt_size = 0;
> unsigned int i;
> @@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
> * Validate the stream configuration response verifying padding is correctly
> * set and the returned number of streams is supported
> */
> -static const int gb_camera_configure_streams_validate_response(
> - struct gb_camera *gcam,
> +static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
Why change this line?
It's fine, but then:
> struct gb_camera_configure_streams_response *resp,
> unsigned int nstreams)
These lines are not fixed up?
thanks,
greg k-h
Powered by blists - more mailing lists