linux-kernel - Re: [PATCH] x86/percpu: Introduce const-qualified const_pcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46C29ACB-0CC2-4484-A3D3-11F33FD08BEB@vmware.com>
Date:   Sat, 21 Oct 2023 14:27:10 +0000
From:   Nadav Amit <namit@...are.com>
To:     Uros Bizjak <ubizjak@...il.com>
CC:     the arch/x86 maintainers <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Brian Gerst <brgerst@...il.com>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        "H . Peter Anvin" <hpa@...or.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [PATCH] x86/percpu: Introduce const-qualified const_pcpu_hot



> On Oct 20, 2023, at 7:19 PM, Uros Bizjak <ubizjak@...il.com> wrote:
> 
> By implementing constant-qualified const_pcpu_hot, the compiler can
> eliminate redundant reads from the constant variables, reducing the
> number of loads from current_task from 3766 to 3217 on a test build,
> a -14.6% reduction.

Thanks again for doing that. LGTM! [*]

--

[*] The negative sign here is unneeded, but that’s just me being
    negative. ;-)