[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANEJEGtmFWRkaxzqCXZQC4yfwnYtAsMFHEOU8+SMOFdHqLT+3A@mail.gmail.com>
Date: Sat, 21 Oct 2023 07:50:17 -0700
From: Grant Grundler <grundler@...omium.org>
To: Douglas Anderson <dianders@...omium.org>
Cc: Jakub Kicinski <kuba@...nel.org>,
Hayes Wang <hayeswang@...ltek.com>,
"David S . Miller" <davem@...emloft.net>,
Edward Hill <ecgh@...omium.org>,
Laura Nao <laura.nao@...labora.com>,
Alan Stern <stern@...land.harvard.edu>,
Simon Horman <horms@...nel.org>, linux-usb@...r.kernel.org,
Grant Grundler <grundler@...omium.org>,
Bjørn Mork <bjorn@...k.no>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH v5 2/8] r8152: Run the unload routine if we have errors
during probe
On Fri, Oct 20, 2023 at 2:08 PM Douglas Anderson <dianders@...omium.org> wrote:
>
> The rtl8152_probe() function lacks a call to the chip-specific
> unload() routine when it sees an error in probe. Add it in to match
> the cleanup code in rtl8152_disconnect().
>
> Fixes: ac718b69301c ("net/usb: new driver for RTL8152")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
Reviewed-by: Grant Grundler <grundler@...omium.org>
> ---
>
> Changes in v5:
> - ("Run the unload routine if we have errors during probe") new for v5.
>
> drivers/net/usb/r8152.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 482957beae66..201c688e3e3f 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -9783,6 +9783,8 @@ static int rtl8152_probe(struct usb_interface *intf,
>
> out1:
> tasklet_kill(&tp->tx_tl);
> + if (tp->rtl_ops.unload)
> + tp->rtl_ops.unload(tp);
> usb_set_intfdata(intf, NULL);
> out:
> free_netdev(netdev);
> --
> 2.42.0.758.gaed0368e0e-goog
>
Powered by blists - more mailing lists