linux-kernel - Re: [PATCH v4 01/11] tty: 8250: Fix IS-200 PCI ID comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023102107-poser-recipient-3593@gregkh>
Date:   Sat, 21 Oct 2023 18:19:34 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Cameron Williams <cang1@...e.co.uk>
Cc:     jirislaby@...nel.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v4 01/11] tty: 8250: Fix IS-200 PCI ID comment

On Fri, Oct 20, 2023 at 05:03:07PM +0100, Cameron Williams wrote:
> Fix the PCI comment for the IS-200 card. The PCI ID for the IS-200
> is 0x0d80, and the definition used (PCI_DEVICE_ID_INTASHIELD_IS200)
> is indeed 0x0d80, clarify that by fixing the comment as its
> neighbouring cards are all at 0x0020 offsets.
> 
> Fixes: 737c17561fb2 ("[SERIAL] Support for Intashield 2 port PCI serial card")
> Cc: stable@...r.kernel.org
> Signed-off-by: Cameron Williams <cang1@...e.co.uk>
> ---
> I argue for fixing this rather than removing due to this patch series (and
> the code already in the kernel) referring to the rest of the cards in
> the manufacturer's product line by hex ID, makes sense to me to
> have the hex IDs all displayed correctly one way or another in the
> one driver as the IS-200 and 400 are the only cards to use a definition instead.

I'll take this, but it is obviously not for stable kernels to take, as
it has no code functional changes.

thanks,

greg k-h