linux-kernel - Re: [PATCH] power: supply: charger-manager: replace deprecated strncpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169784959122.1512524.17275327804996893357.b4-ty@collabora.com>
Date:   Sat, 21 Oct 2023 02:53:11 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Sebastian Reichel <sre@...nel.org>,
        Justin Stitt <justinstitt@...gle.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] power: supply: charger-manager: replace deprecated
 strncpy with strscpy


On Fri, 20 Oct 2023 19:21:46 +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> 
> We expect cm->psy_name_buf to be NUL-terminated based on its usage with
> format strings:
> 1522: cm->charger_psy_desc.name = cm->psy_name_buf;
> ...
> 1587: dev_err(&pdev->dev, "Cannot register charger-manager with name \"%s\"\n",
> 1587:   cm->charger_psy_desc.name);
> 
> [...]

Applied, thanks!

[1/1] power: supply: charger-manager: replace deprecated strncpy with strscpy
      commit: e1402bd297a3477c16eca4c1e4094372237f40a7

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@...labora.com>