linux-kernel - Re: [PATCH] drm/panfrost: Remove incorrect IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <y5k6fhinzwd6yhbskvkaeiywp7vcsri3macjlwz3s7ug57erth@5foiaaf3hkr7>
Date:   Sat, 21 Oct 2023 19:44:28 +0100
From:   Adrián Larumbe <adrian.larumbe@...labora.com>
To:     Steven Price <steven.price@....com>
Cc:     Boris Brezillon <boris.brezillon@...labora.com>,
        Rob Herring <robh@...nel.org>, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH] drm/panfrost: Remove incorrect IS_ERR() check

On 20.10.2023 11:44, Steven Price wrote:
> sg_page_iter_page() doesn't return an error code, so the IS_ERR() check
> is wrong and the error path will never be executed. This also allows
> simplifying the code to remove the local variable 'page'.
> 
> CC: Adrián Larumbe <adrian.larumbe@...labora.com>
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/r/376713ff-9a4f-4ea3-b097-fb5efb685d95@moroto.mountain
> Signed-off-by: Steven Price <steven.price@....com>

Reviewed-by: Adrián Larumbe <adrian.larumbe@...labora.com>
Tested-by: Adrián Larumbe <adrian.larumbe@...labora.com>

> ---
>  drivers/gpu/drm/panfrost/panfrost_dump.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_dump.c b/drivers/gpu/drm/panfrost/panfrost_dump.c
> index e7942ac449c6..47751302f1bc 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_dump.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_dump.c
> @@ -220,16 +220,8 @@ void panfrost_core_dump(struct panfrost_job *job)
>  
>  		iter.hdr->bomap.data[0] = bomap - bomap_start;
>  
> -		for_each_sgtable_page(bo->base.sgt, &page_iter, 0) {
> -			struct page *page = sg_page_iter_page(&page_iter);
> -
> -			if (!IS_ERR(page)) {
> -				*bomap++ = page_to_phys(page);
> -			} else {
> -				dev_err(pfdev->dev, "Panfrost Dump: wrong page\n");
> -				*bomap++ = 0;
> -			}
> -		}
> +		for_each_sgtable_page(bo->base.sgt, &page_iter, 0)
> +			*bomap++ = page_to_phys(sg_page_iter_page(&page_iter));
>  
>  		iter.hdr->bomap.iova = mapping->mmnode.start << PAGE_SHIFT;
>  
> -- 
> 2.34.1