linux-kernel - Re: [PATCH v3 1/2] misc: rtsx: add to support new card reader rts5264

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023102153-paramedic-washboard-29e3@gregkh>
Date:   Sat, 21 Oct 2023 22:57:06 +0200
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Ricky WU <ricky_wu@...ltek.com>
Cc:     "arnd@...db.de" <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "frank.li@...o.com" <frank.li@...o.com>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        "yangyingliang@...wei.com" <yangyingliang@...wei.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] misc: rtsx: add to support new card reader rts5264

On Fri, Oct 20, 2023 at 08:13:46AM +0000, Ricky WU wrote:
> In order to support new chip rts5264, the definitions of some internal
> registers and workflow have to be modified.

That is fine, but that should be a single patch, right?

> Added rts5264.c rts5264.h for independent functions of the new chip rts5264

And then add new support in a new patch, this is still too big as one
patch to attempt to review it properly.  Would you like to review this
as-is?

thanks,

greg k-h