linux-kernel - Re: [PATCH 3/3] sched: Update ->next_balance correctly during newidle balance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTN0xgGNefllUm7Q@gmail.com>
Date:   Sat, 21 Oct 2023 08:50:46 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Vincent Guittot <vincent.guittot@...aro.org>
Cc:     "Joel Fernandes (Google)" <joel@...lfernandes.org>,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Valentin Schneider <vschneid@...hat.com>,
        "Vineeth Pillai (Google)" <vineeth@...byteword.org>,
        Suleiman Souhlal <suleiman@...gle.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        "Paul E . McKenney" <paulmck@...nel.org>
Subject: Re: [PATCH 3/3] sched: Update ->next_balance correctly during
 newidle balance


* Vincent Guittot <vincent.guittot@...aro.org> wrote:

> Hi Ingo,
> 
> On Fri, 20 Oct 2023 at 09:53, Ingo Molnar <mingo@...nel.org> wrote:
> >
> >
> 
> ...
> 
> > >                       curr_cost += domain_cost;
> > >                       t0 = t1;
> >
> > Okay, I'm applying patches #2 and #3, without #1: it should be safe
> > out of order, but let me know if I missed something ...
> 
> Could you hold on for patch 3 ? As replied to Joel, the patch had
> regression in the update of rq->next_balance

Yeah, patch #3 is gone already from tip:sched/core.

Thanks,

	Ingo