linux-kernel - Re: [PATCH] staging: rtl8192e: renamed varaible HTIOTActIsDisableMCS15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1cf90dc0-7b7e-4639-b71c-a2a1f7fba11f@gmail.com>
Date:   Sun, 22 Oct 2023 08:33:24 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Gary Rookard <garyrookard@...tmail.org>, gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: renamed varaible
 HTIOTActIsDisableMCS15

On 10/22/23 01:53, Gary Rookard wrote:
> Renamed from Pascal/CamelCase to Snake case the variable
> HTIOCActIsDisableMCS15, HTIOTActIsDisableMCS15 -> ht_ioc_act_disable_mcs15.
> 
> Linux kernel coding style (cleanup), checkpatch Avoid CamelCase
> Driver rtl8192e compiles.
> 
> Signed-off-by: Gary Rookard <garyrookard@...tmail.org>
> ---
>   drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 5dca97b07874..8868672131a1 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -212,7 +212,7 @@ static u8 ht_iot_act_is_disable_mcs14(struct rtllib_device *ieee, u8 *PeerMacAdd
>   	return 0;
>   }
>   
> -static bool HTIOTActIsDisableMCS15(struct rtllib_device *ieee)
> +static bool ht_iot_act_is_disable_mcs15(struct rtllib_device *ieee)
>   {
>   	return false;
>   }
> @@ -700,7 +700,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
>   		if (bIOTAction)
>   			ht_info->iot_action |= HT_IOT_ACT_DISABLE_MCS14;
>   
> -		bIOTAction = HTIOTActIsDisableMCS15(ieee);
> +		bIOTAction = ht_iot_act_is_disable_mcs15(ieee);
>   		if (bIOTAction)
>   			ht_info->iot_action |= HT_IOT_ACT_DISABLE_MCS15;
>   

Hi,

please use checkpatch on your patches.

WARNING: 'varaible' may be misspelled - perhaps 'variable'?
#4:
Subject: [PATCH] staging: rtl8192e: renamed varaible HTIOTActIsDisableMCS15
                                             ^^^^^^^^

Bye Philipp